Log scrobblings

app/controllers/application_controller.rb

@@ -50,8 +50,22 @@ class ApplicationController < ActionController::Base
   
 protected
 
-  def cache_key_for object
-    "#{object.class.to_s.underscore}_#{object.id}"
+  def session
+    Session.find_by_key(session_key)
+  end
+  
+  def current_user
+    session.user if current_user?
+  end
+  
+  def current_user?
+    !session.nil? and !session.user.nil?
+  end
+  
+  def set_locale
+    unless session.nil?
+      I18n.locale = session.user.lang
+    end
   end
   
   def authorize
@@ -60,13 +74,6 @@ protected
     end
   end
   
-  def set_locale
-    session = Session.find_by_key(session_key)
-    unless session.nil?
-      I18n.locale = session.user.lang
-    end
-  end
-  
   def session_key
     if cookies[:beathaven_sid].nil?
       cookies[:beathaven_sid] = {
@@ -77,6 +84,10 @@ protected
     cookies[:beathaven_sid]
   end
   
+  def cache_key_for object
+    "#{object.class.to_s.underscore}_#{object.id}"
+  end
+  
   def render_compact_partial partial_name
     (render_to_string :partial => partial_name.to_s).gsub(/\n(\s+)?/, '')
   end

app/controllers/last_fm_controller.rb

@@ -2,22 +2,22 @@ require 'open-uri'
 require 'net/http'
 
 class LastFmController < ApplicationController
-  before_filter :authorize, :except => [:connect, :autocomplete]
+  before_filter :authorize, except: [:connect, :autocomplete]
   
   def connect
     unless params[:sid].nil? or params[:token].nil?
-      session = Session.find_by_key(params[:sid])
-      unless session.nil?
-        lastfm_api_session = LastFM::Auth.get_session(:token => params[:token], :api_sig => true)
-        session.user.lastfm_key = lastfm_api_session["session"]['key']
-        session.user.lastfm_username = lastfm_api_session["session"]['name']
-        session.user.save
-        render :text => '<script>window.close();</script>'
+      if current_user?
+        lastfm_api_session = LastFM::Auth.get_session(token: params[:token], api_sig: true)
+        user = current_user
+        user.lastfm_key = lastfm_api_session["session"]['key']
+        user.lastfm_username = lastfm_api_session["session"]['name']
+        user.save
+        return render text: "<script>window.close();</script>"
       else
-        return render :text => 'You Don\'t Fool Me', status: 403
+        return render text: "You Don't Fool Me", status: 403
       end
     else
-      return render :text => 'So Much Trouble In The World', status: 403
+      return render text: "So Much Trouble In The World", status: 403
     end
   end
   
@@ -25,15 +25,15 @@ class LastFmController < ApplicationController
     @res = {}
     user = User.find_by_vkid(params[:mid])
     unless user.lastfm_key.nil?
-      render :json => {
-        :connected => true,
-        :username => user.lastfm_username
+      render json: {
+        connected: true,
+        username: user.lastfm_username
       }
     else
-      render :json => {
-        :connected => false,
-        :lastfm_login_url => 'http://www.last.fm/api/auth?api_key='+ LastFM.api_key +
-          '&cb=http://'+ request.host << '/lastfm/connect/?sid='+ user.session.key
+      render json: {
+        connected: false,
+        lastfm_login_url: "http://www.last.fm/api/auth?api_key=#{LastFM.api_key}"+
+          "&cb=http://#{request.host}:#{request.port.to_s}/lastfm/connect/?sid=#{user.session.key}"
       }
     end
   end
@@ -41,42 +41,43 @@ class LastFmController < ApplicationController
   def listening
     @res = {}
     if params[:artist].nil? or params[:album].nil? or params[:name].nil?
-      return render :json => { :status => 'bad params' }, status: 403
+      return render json: { status: 'bad params' }, status: 403
     end
-    user = User.find_by_vkid(params[:mid])
-    if user.lastfm_key.nil?
-      return render :json => {:status => 'lastfm account is not connected', :user => user}
+    if !current_user? or (current_user.lastfm_key.nil? or current_user.lastfm_key == "")
+      return render json: {status: 'lastfm account is not connected' }
     end
     r = LastFM::Track.update_now_playing(
-      :track => params[:name],
-      :artist => params[:artist],
-      :album => params[:album],
-      :trackNumber => params[:position].gsub(/[a-z]/, "").to_i,
-      :duration => params[:length].to_i,
-      :sk => user.lastfm_key # Auth session key
+      track: params[:name],
+      artist: params[:artist],
+      album: params[:album],
+      trackNumber: params[:position].gsub(/[a-z]/, "").to_i,
+      duration: params[:length].to_i,
+      sk: current_user.lastfm_key # Auth session key
     )
-    render :json => { :status => r['error'].nil? ? 'success' : r }, :status => r['error'].nil? ? 200 : 403
+    render json: { status: r['error'].nil? ? 'success' : r }, status: r['error'].nil? ? 200 : 403
   end
   
   def scrobble
     @res = {}
     if params[:artist].nil? or params[:album].nil? or params[:name].nil?
-      return render :json => { :status => 'bad params' }, status: 403
+      return render json: { status: 'bad params' }, status: 403
     end
-    user = User.find_by_vkid(params[:mid])
-    if user.lastfm_key.nil?
-      return render :json => { :status => 'lastfm account is not connected', :user => user }
+    if current_user? and track = Track.find_by_id(params[:id])
+      Scrobble.create(user: current_user, track: track, scrobbled_at: DateTime.now)
+    end
+    if !current_user? or (current_user.lastfm_key.nil? or current_user.lastfm_key == "")
+      return render json: { status: 'lastfm account is not connected' }
     end
     r = LastFM::Track.scrobble(
-      :track => params[:name],
-      :timestamp => Time.now.utc.to_i,
-      :artist => params[:artist],
-      :album => params[:album],
-      :trackNumber => params[:position].gsub(/[a-z]/, "").to_i,
-      :duration => params[:length].to_i,
-      :sk => user.lastfm_key # Auth session key
+      track: params[:name],
+      timestamp: Time.now.utc.to_i,
+      artist: params[:artist],
+      album: params[:album],
+      trackNumber: params[:position].gsub(/[a-z]/, "").to_i,
+      duration: params[:length].to_i,
+      sk: current_user.lastfm_key # Auth session key
     )
-    render :json => { :status => r['error'].nil? ? 'success' : r }, :status => r['error'].nil? ? 200 : 403
+    render json: { status: r['error'].nil? ? 'success' : r }, status: r['error'].nil? ? 200 : 403
   end
   
   def self.top_playlist artist
@@ -89,16 +90,16 @@ class LastFmController < ApplicationController
   
   def autocomplete
     autocomplete = getSuggestions(params[:query])
-    return render :nothing => true if autocomplete.nil?
+    return render nothing: true if autocomplete.nil?
     suggestions = []
     autocomplete["response"]["docs"].each do |doc|
       suggestions << doc["artist"] unless suggestions.include?(doc["artist"]) or doc["artist"].nil? or doc['restype'] != 6
     end
 
     response.headers['Cache-Control'] = 'public, max-age='+1.week.seconds.to_s
-    render :json => {
-      :query => params[:query],
-      :suggestions => suggestions.take(5)
+    render json: {
+      query: params[:query],
+      suggestions: suggestions.take(5)
     }
   end
   

app/controllers/user_controller.rb

@@ -28,7 +28,7 @@ class UserController < ApplicationController
   end
   
   def update
-    allowed_params = [:name, :email, :lang, :show, :lastfm_username, :lastfm_token]
+    allowed_params = [:name, :email, :lang, :show, :lastfm_username, :lastfm_key]
     
     user = User.find_by_vkid(params[:mid])
     unless params[:params].nil?
@@ -85,9 +85,8 @@ private
       vkid: user.vkid,
       lang: user.lang,
       lastfm_username: user.lastfm_username,
-      lastfm_login_url: ('http://www.last.fm/api/auth?api_key=' << LastFM.api_key <<
-        '&cb=http://' << request.host << ':' << request.port.to_s << '/lastfm/connect/?sid=' <<
-        user.session.key if user.lastfm_username.nil? or user.lastfm_username == "")
+      lastfm_login_url: "http://www.last.fm/api/auth?api_key=#{LastFM.api_key}"+
+        "&cb=http://#{request.host}:#{request.port.to_s}/lastfm/connect/?sid=#{user.session.key}"
     }
   end
 end