From 344dfdbe5c62f294466a00887e560a0adfca5de6 Mon Sep 17 00:00:00 2001 From: Savater Sebastien Date: Thu, 11 Jul 2013 22:51:50 +0400 Subject: [PATCH 1/2] Do not rescue all errors --- lib/musicbrainz/client_modules/transparent_proxy.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/musicbrainz/client_modules/transparent_proxy.rb b/lib/musicbrainz/client_modules/transparent_proxy.rb index c78ee7c..28d383f 100644 --- a/lib/musicbrainz/client_modules/transparent_proxy.rb +++ b/lib/musicbrainz/client_modules/transparent_proxy.rb @@ -4,8 +4,6 @@ module MusicBrainz def get_contents(url) response = http.get(url) { body: response.body, status: response.status } - rescue - { body: nil, status: 500 } end end end From b01795d55c95e7d9383426fa21695748768bf5a2 Mon Sep 17 00:00:00 2001 From: Savater Sebastien Date: Sat, 13 Jul 2013 14:26:57 +0400 Subject: [PATCH 2/2] Handle faraday errors --- lib/musicbrainz/client_modules/transparent_proxy.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/musicbrainz/client_modules/transparent_proxy.rb b/lib/musicbrainz/client_modules/transparent_proxy.rb index 28d383f..e3386f6 100644 --- a/lib/musicbrainz/client_modules/transparent_proxy.rb +++ b/lib/musicbrainz/client_modules/transparent_proxy.rb @@ -4,6 +4,8 @@ module MusicBrainz def get_contents(url) response = http.get(url) { body: response.body, status: response.status } + rescue Faraday::Error::ClientError + { body: nil, status: 500 } end end end