From 89d7c1f584726cc7b4df85ffb4608d2b407b0079 Mon Sep 17 00:00:00 2001 From: Gregory Eremin Date: Tue, 12 Aug 2014 15:23:22 +0700 Subject: [PATCH] Don't forget to close buffer in tests --- buffer_test.go | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/buffer_test.go b/buffer_test.go index de5aa99..4826264 100644 --- a/buffer_test.go +++ b/buffer_test.go @@ -10,6 +10,7 @@ import ( func TestNewBuffer(t *testing.T) { fn := func(series []*influxdb.Series) {} b := NewBuffer(10, fn) + defer b.Close() if b == nil { t.Error("Failed to instantiate buffer with `NewBuffer` function") @@ -19,6 +20,7 @@ func TestNewBuffer(t *testing.T) { func TestAdd(t *testing.T) { fn := func(series []*influxdb.Series) {} b := NewBuffer(10, fn) + defer b.Close() if b.Size() != 0 { t.Error("Freshly created buffer is not empty") @@ -33,10 +35,9 @@ func TestAdd(t *testing.T) { func TestFlush(t *testing.T) { res := make(chan []*influxdb.Series, 1) - fn := func(series []*influxdb.Series) { - res <- series - } + fn := func(series []*influxdb.Series) { res <- series } b := NewBuffer(1, fn) + defer b.Close() b.Add(&influxdb.Series{}) timer := time.NewTimer(time.Second) @@ -55,6 +56,7 @@ func TestFlush(t *testing.T) { func TestLookup(t *testing.T) { fn := func(series []*influxdb.Series) {} b := NewBuffer(10, fn) + defer b.Close() b.Add( &influxdb.Series{ Name: "foo", @@ -174,10 +176,9 @@ func TestClose(t *testing.T) { func TestAggregate(t *testing.T) { res := make(chan []*influxdb.Series, 1) - fn := func(series []*influxdb.Series) { - res <- series - } + fn := func(series []*influxdb.Series) { res <- series } b := NewBuffer(3, fn) + defer b.Close() b.Add( &influxdb.Series{ Name: "foo",